Update to winit 0.29

[fornwall]

• Closes Update to winit 0.29 #3542
• Closes Forward scancodes via egui-winit #2977
• Closes Add non-portable keys to egui::Key #3303

[fornwall]

Current status: At least on mac, running cargo run --release -p egui_demo_app brings up the window and it can be resized, but not interacted with.

[emilk]

Is there a situation where the key event is other than "Pressed" but text is produced?

Maybe IME? 🤷

[PingPongun]

I prepared patch that updates resvg to v0.36 (issue: #3652):
update_resvg_0_36.patch

I think it matches in this PR as:

• both resvg and winit (through sctk-adwaita) depend on tiny-skia, so updating them separately results in dependency duplication and cargo-deny fail.
• there were already some small changes related to svg (commits b4e6246 & 7c89b67) and deny.toml (0dbd597) in this PR

In example images ferris is scaled differently, but I guess that now it scales in expected way (takes all available space; before this patch it takes up to space that, was available at first render- it does not upscale).

Digression 1

This patch is minimal adaptation to new resvg api and small related simplification, however it should be considered to update loaders (currently if svg image initially was small and was scaled up it will be blurred, see #3501). As svg image can now scale over render size, problem will be more often seen now.

(currently SvgLoader theoretically should rerender for different sizes (but will result in memory leak in that case), but refreshing is stopped earlier in DefaultTextureLoader).

I have some ideas on updating loaders (it will fix issue with svg and enable reloading image if file has been changed):

• add two more variants to ImagePoll/BytesPoll (Changing(old_data) & Changed(new_data))

• change order of loader tasks (currently is: 1. check if loader has image cached, 2. if not call lower level loader -> change to -> 1. call lower level loader 2. if lower level is not changed load cached)

• SvgLoader:

  • store resvg::Tree & SizeHint in svg_loader::Entry

  • remove SizeHint from SvgLoader hashmap key

  • one of the following:

    • rerender svg if image size has been changed,
    • render dynamically (first approach will equal second one if there are multiple images from the same file but in different scale),
    • rerender svg if new image size is larger than rendered one (I guess this will be most performant, but there may be some minor down-scalling artifacts)

As these will require changes that are completely unrelated to winit, I guess it will better fit into separate PR, after this PR is merged.

Digression 2: check.sh installs cranky, but does not install typos nor cargo-deny that are also needed

[emilk]

@PingPongun thanks for the patch, but let's wait with the resvg update for a separate PR - this one is big enough as is 😓

[YgorSouza]

I was testing to see if this branch fixes #3673, which it does, but on my machine it makes the main viewport on the demo app stop repainting whenever it is in the foreground and the extra viewport is open. The person who opened the issue did not observe the same behavior on their machine, which has a similar but different setup.

winit_029_demo_app.mp4

Here is my setup:

OS: Fedora Linux 38 (Workstation Edition) x86_64 
Host: Laptop (12th Gen Intel Core) A6 
Kernel: 6.6.2-101.fc38.x86_64 
Resolution: 2256x1504 
DE: GNOME 44.6 
WM: Mutter 
WM Theme: Adwaita 
Theme: Adwaita-dark [GTK2/3] 
Icons: Adwaita [GTK2/3] 
CPU: 12th Gen Intel i7-1260P (16) @ 4.700GHz 
GPU: Intel Alder Lake-P GT2 [Iris Xe Graphics] 

[YgorSouza]

Another problem I found: the modifier keys are ignored. Both the left and the right ones. They don't appear as down in the inspection window in the demo app, and they don't have any other effect either (aside from making text upper case, in the case of the shift key).

[emilk]

According to @Wumpf this seems to work pretty well on Windows now.

[emilk]

IME seems to work on my Mac.

Are there any more blockers to merging this?

[Vickerinox]

Just tried it out on Linux Mint 21.2, everything seems to be working perfectly aside from window dragging, which causes the window to fly into the top left corner of the screen (see video) I've tested to make sure every letter on my keyboard works + modifiers, as well as the various demos in the demo app. Nothing obvious that's different aside form the previously mentioned bug.

out.mp4

[emilk]

Thanks @Vickerinox - I think that is an acceptable level of regression. If anyone wants that feature to work they can make a PR :)