Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indeterminate state to checkbox #3605

Merged
merged 4 commits into from Jan 6, 2024

Conversation

YgorSouza
Copy link
Contributor

No description provided.

@YgorSouza
Copy link
Contributor Author

Screencast.from.2023-11-21.21-38-32.webm

@DataTriny
Copy link
Contributor

Hello,

In case of an indeterminate checked state, Checked::Mixed must be passed to NodeBuilder::set_checked when an accessible node is built here.

@DataTriny
Copy link
Contributor

From an accessibility standpoint this is now OK, the state of the check box in the demo app is correctly picked up by ATs. Thanks!

@emilk emilk added the egui label Jan 6, 2024
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

crates/egui/src/widgets/button.rs Outdated Show resolved Hide resolved
crates/egui/src/widgets/button.rs Outdated Show resolved Hide resolved
@emilk emilk merged commit 797406d into emilk:master Jan 6, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants