Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Color32::from_hex_string and Color32::to_hex_string #3570

Merged
merged 2 commits into from Jan 7, 2024
Merged

Add Color32::from_hex_string and Color32::to_hex_string #3570

merged 2 commits into from Jan 7, 2024

Conversation

YgorSouza
Copy link
Contributor

Closes #3466.

@emilk
Copy link
Owner

emilk commented Jan 6, 2024

Nice feature addition!

One thing though: hex colors are generally expected to use unmultiplied/separate alpha

emilk
emilk approved these changes Jan 7, 2024
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@emilk emilk changed the title Implement conversion between hex-string and Color32 Add Color32::from_hex_string and Color32::to_hex_string Jan 7, 2024
@emilk emilk merged commit 669473c into emilk:master Jan 7, 2024
20 of 21 checks passed
@emilk emilk added the ecolor label Jan 7, 2024
@emilk emilk mentioned this pull request Jan 7, 2024
Merged
emilk added a commit that referenced this pull request Jan 7, 2024
@emilk
Rename from_hex_string -> from_hex, and to_hex_string -> `to_he…
51e5d28 
…x` (#3777)

Follow-up to #3570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
ecolor egui epaint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hex string to Color32, Color 32 to hex string
2 participants
@YgorSouza @emilk