Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: allow using the full Private Use Area for custom fonts #3509

Merged

Conversation

varphone
Copy link
Contributor

The ignored characters are used in some custom fonts.

for example: the \u{F0FF} is used as cleaning_services in MaterialIcons-Regular.ttf

Closes https://github.com/emilk/egui/issues/THE_RELEVANT_ISSUE.

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a better way to do this - only ignore '\u{E0FF}' | '\u{EFFD}' | '\u{F0FF}' | '\u{F200}' for Ubuntu-Light

The ignored characters are used in some custom fonts.

for example: the \u{F0FF} is used as `cleaning_services` in MaterialIcons-Regular.ttf
@varphone varphone force-pushed the feature/no-ignore-character-for-non-builtin-fonts branch from 3e6cd74 to 53fa725 Compare December 15, 2023 08:50
crates/epaint/src/text/font.rs Show resolved Hide resolved
@emilk emilk added the epaint label Jan 6, 2024
@emilk emilk changed the title Limit FontImpl::ignore_character to builtin fonts only Fix: allow using the full Private Use Area for custom fonts Jan 6, 2024
@emilk emilk added the egui label Jan 6, 2024
crates/epaint/src/text/font.rs Outdated Show resolved Hide resolved
@emilk emilk merged commit 932fdae into emilk:master Jan 6, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants