New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added key mappings for [
, ]
, ,
and \
#3373
Conversation
39cc3ba
to
056fffe
Compare
0965358
to
1be359f
Compare
Have you tested this on web? |
works on web for me. |
4a72063
to
2f8e69b
Compare
rebased the PR on current HEAD - no conflicts. |
Thanks for the PR! Unfortunately this requires another rebase 😬 |
2f8e69b
to
00ef4f1
Compare
there were many changes in that area :/ - comma got already added now - others are missing. There are surely plenty of keys that are currently not supported. I only added the ones I need for my terminal program. |
00ef4f1
to
8a3401e
Compare
crates/egui/src/data/input.rs
Outdated
CloseBracket, | ||
|
||
/// '`' | ||
Backquote, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has many different names, but I suggest we follow wikipedia (https://en.wikipedia.org/wiki/Backtick) and call it Backtick
, but add "backquote" and "grave" as pseudonyms in the docstring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed - I don't mind how it's called doesn't matter if it's grave, backtick or backquote - I just need the key :).
8a3401e
to
10ee4e5
Compare
[
, ]
, ,
and \
.
|
10ee4e5
to
46ab314
Compare
ok fixed - some more renamings. Assumed that a VirtualKeyCode -> KeyCode but they renamed some keys. LBracket -> BracketLeft |
46ab314
to
cd08f3d
Compare
* Closes #3372 * Added Key::Backslash, Key::OpenBracket, Key::CloseBracket, Key::Backquote
cd08f3d
to
15db853
Compare
[
, ]
, ,
and \
.[
, ]
, ,
and \
Added key mappings for '[', ']', ',' and ''.
Added keys