Fix: Non-resizable Areas now ignore mouse input outside their bounds
#3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in emilk#576, the function `Memory::layer_id_at` expands the hit-testing region for every `Area` slightly. This is necessary so that, when the user clicks to resize a `Window`, the mouse input isn't routed to a different `Window`. For non-resizable `Area`s (such as dropdown menus, context menus, date pickers, and any non-resizable `Window`), this causes them to be surrounded by a "dead zone" where any underlying widgets can't be hovered or clicked. The effect is particularly noticeable in menu bars. This commit adds a persisted `edges_padded_for_resize` property to `Area`, which is `true` when the `Area` belongs to a resizable `Window` and `false` for all other `Area`s. The hit-testing region is only expanded when this property is `true`.
|
I'm a little uneasy about my approach here, because it forces |
emilk
approved these changes
Aug 9, 2023
|
I'm not sure why the CI isn't kicking in. Perhaps try merging in latest |
emilk
changed the title
Areas now ignore mouse input outside their bounds
emilk
added a commit
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #576, the method
Memory::layer_id_atexpands the hit-testing region for everyAreaslightly. This is necessary so that, when the user clicks to resize aWindow, the mouse input isn't routed to a differentWindow.For non-resizable
Areas (such as dropdown menus, context menus, date pickers, and any non-resizableWindow), this causes them to be surrounded by a "dead zone" where any underlying widgets can't be hovered or clicked. The effect is particularly noticeable in menu bars.This commit adds a persisted
edges_padded_for_resizeproperty toArea, which istruewhen theAreabelongs to a resizableWindowandfalsefor all otherAreas. The hit-testing region is only expanded when this property istrue.