Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added key mappings for [, ], , and \ #3373

Merged
merged 1 commit into from Jan 8, 2024
Merged

Added key mappings for [, ], , and \ #3373

merged 1 commit into from Jan 8, 2024

Conversation

mkrueger
Copy link
Contributor

@mkrueger mkrueger commented Sep 23, 2023 •
edited

Added key mappings for '[', ']', ',' and ''.

Added keys

  • egui::Key::Backslash
  • egui::Key::OpenBracket
  • egui::Key::CloseBracket
  • egui::Key::Comma

@mkrueger mkrueger force-pushed the dev/mkrueger/key_codes branch 2 times, most recently from 39cc3ba to 056fffe Compare September 23, 2023 04:04
@mkrueger mkrueger mentioned this pull request Sep 23, 2023
Closed
@mkrueger mkrueger force-pushed the dev/mkrueger/key_codes branch 2 times, most recently from 0965358 to 1be359f Compare September 23, 2023 04:20
@mkrueger mkrueger mentioned this pull request Oct 9, 2023
Closed
emilk
emilk approved these changes Nov 10, 2023
View reviewed changes
crates/egui/src/data/input.rs Outdated Show resolved Hide resolved
@emilk
Copy link
Owner

emilk commented Nov 10, 2023

Have you tested this on web?

@mkrueger
Copy link
Contributor Author

works on web for me.

@mkrueger
Copy link
Contributor Author

mkrueger commented Dec 1, 2023

rebased the PR on current HEAD - no conflicts.

@emilk
Copy link
Owner

emilk commented Jan 6, 2024

Thanks for the PR! Unfortunately this requires another rebase 😬

@mkrueger
Copy link
Contributor Author

mkrueger commented Jan 7, 2024 •
edited

there were many changes in that area :/ - comma got already added now - others are missing. There are surely plenty of keys that are currently not supported. I only added the ones I need for my terminal program.

emilk
emilk reviewed Jan 7, 2024
View reviewed changes
crates/egui/src/data/input.rs Outdated
CloseBracket,

/// '`'
Backquote,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has many different names, but I suggest we follow wikipedia (https://en.wikipedia.org/wiki/Backtick) and call it Backtick, but add "backquote" and "grave" as pseudonyms in the docstring.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed - I don't mind how it's called doesn't matter if it's grave, backtick or backquote - I just need the key :).

@emilk emilk added eframe Relates to epi and eframe egui labels Jan 8, 2024
@emilk emilk changed the title Added key mappings for '[', ']', ',' and '\'. Added key mappings for [, ], , and \. Jan 8, 2024
@emilk
Copy link
Owner

emilk commented Jan 8, 2024 •
edited

cargo check --locked --all-features --all-targets fails

@mkrueger
Copy link
Contributor Author

mkrueger commented Jan 8, 2024

ok fixed - some more renamings. Assumed that a VirtualKeyCode -> KeyCode but they renamed some keys.

LBracket -> BracketLeft
RBracket -> BracketRight
Grave -> Backquote :)

Added key mappings for '[', ']', '`' and '\'.
15db853 
* Closes #3372
* Added Key::Backslash, Key::OpenBracket, Key::CloseBracket, Key::Backquote
@emilk emilk merged commit 8b4c9fd into emilk:master Jan 8, 2024
19 checks passed
@emilk emilk changed the title Added key mappings for [, ], , and \. Added key mappings for [, ], , and \ Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
eframe Relates to epi and eframe egui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need more key mappings
2 participants
@mkrueger @emilk