Avoid crashing the rollup watchmode build when glint hits a syntax error #2342
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
previously approved these changes
Mar 5, 2025
abeforgit
commented
Mar 5, 2025
| let glintPromise: Promise<void>; | ||
|
|
||
| return { | ||
| name: 'glint-dts', | ||
| buildStart: () => { | ||
| buildStart() { |
There was a problem hiding this comment.
had to change this to method syntax to get access to this, unsure of the impact that might have. Other plugins seem to do this as well
NullVoxPopuli
approved these changes
Mar 5, 2025
|
Don't immediately see why these tests would fail, let me know if there's anything I can do |
|
looks like it was just windows being flaky (I reran) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the issue, you don't want the build watching script to completely exit when it hits a syntax error. This means you have to restart
pnpm startonce you've fixed the error, which is annoying.fixes #2341