Use rollup's addWatchFile API to mark dependencies
#1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One example of the issue this fixes is that, currently, in a v2 addon, if you add a new file in the |
chancancode
added a commit
to chancancode/discourse
that referenced
this pull request
Dec 5, 2023
|
Based on your comments it look like this probably bumps the minimum supported rollup version? That would be OK but we should document it and consider whether this should be a semver major of |
|
if this end up requiring major, may be bundled with #1697 |
chancancode
added a commit
to chancancode/discourse
that referenced
this pull request
Dec 5, 2023
|
No it would if we had wanted to call it inline in generateBundle, but that’s why I split it out |
|
Possibly place to add a test if it's not hard: https://github.com/embroider-build/embroider/blob/main/tests/scenarios/v2-addon-dev-watch-test.ts |
chancancode
added a commit
to chancancode/embroider
that referenced
this pull request
Dec 5, 2023
Ran into bugs/issues with using polling mode when writing tests for embroider-build#1696, specifically that on my macOS dev environment using polling, when watching a directory it doesn't seem to consistently emit the `added` event. Mainly I wanted to see which, if any, tests fail without this option. It also seemed a bit suspect since rollup/chokidar presumably works on windows out of the box? Even if this is necessary we may want to limit it to the windows test only (can just set `CHOKIDAR_USEPOLLING` on the job level), since this makes things _less_ realistic everywhere else.
chancancode
added a commit
to chancancode/embroider
that referenced
this pull request
Dec 5, 2023
Ran into bugs/issues with using polling mode when writing tests for embroider-build#1696, specifically that on my macOS dev environment using polling, when watching a directory it doesn't seem to consistently emit the `added` event. Mainly I wanted to see which, if any, tests fail without this option. It also seemed a bit suspect since rollup/chokidar presumably works on windows out of the box? Even if this is necessary we may want to limit it to the windows test only (can just set `CHOKIDAR_USEPOLLING` on the job level), since this makes things _less_ realistic everywhere else. (cherry picked from commit a562b4e)
chancancode
force-pushed
the
add-watch-file
branch
from
a674ba1
to
b0abd15
Compare
chancancode
added a commit
to chancancode/embroider
that referenced
this pull request
Dec 6, 2023
This solves a bunch of watch-mode (not) rebuilding issues; as a general rule everytime we probe or read from the file system we should at least consider whether such an annotation is needed. Unfortunately this package doesn't appear to be tested currently, but I have applied the same patch locally and it appears to be working fine.
chancancode
force-pushed
the
add-watch-file
branch
from
0196f65
to
4fcdb2d
Compare
|
I couldn't get the test to work on CI so I split it out into #1711 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a bunch of watch-mode (not) rebuilding issues; as a general rule everytime we probe or read from the file system we should at least consider whether such an annotation is needed.
Unfortunately this package doesn't appear to be tested currently, but I have applied the same patch locally and it appears to be working fine.
If someone has the bandwidth to set up new tests for this package (similar to https://github.com/embroider-build/embroider/blob/main/tests/scenarios/watch-mode-test.ts), I am happy to add the regression tests, but otherwise it probably shouldn't block landing this, I don't think it's making things worse.