[v1.x] fix(analyzer): ignore type-only imports & exports #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buschtoens
force-pushed
the
v1.x-erase-type-imports
branch
from
b47482a
to
2fb4722
Compare
If the TS syntax plugin is not loaded, the following scenarios fail, as the `import type` syntax is not understood: - `lts-own` - `release-own` - `beta-own` - `canary-own`
buschtoens
force-pushed
the
v1.x-erase-type-imports
branch
from
2fb4722
to
2ca08ee
Compare
The `import type` syntax is only available with `babel@7`, but `ember-auto-import@1.x` only tests for `babel@6`. This commit makes the `analyzer` test module run twice: once for `babel@6` an once for `babel@7`, where the latter has a different babel plugin configuration and runs the addition `import type` test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #380 to
v1.x.