[CLEANUP canary] Remove final eager consumption of AMD loader #20620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the last place where Ember treats the AMD loader as mandatory. After this change I have Ember's whole test suite passing with no AMD loader!
NullVoxPopuli
approved these changes
Jan 3, 2024
|
(I thought I had already removed the "ts@next expected" rule from the branch protections but apparently I didn't hit save last time. This PR is passing all other tests and that one will stay yellow forever.) |
|
Oh, nevermind, github updated so we're green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last place where Ember treats the AMD loader as mandatory. After this change I have Ember's whole test suite passing with no AMD loader!