Bump all glimmer-vm dependencies to 0.87.1 #20609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
types are failing because types are failing on main |
NullVoxPopuli
commented
Dec 26, 2023
| @@ -32,18 +31,6 @@ moduleFor( | |||
| ); | |||
| } | |||
|
|
|||
| '@test SUPPORTS_EVENT_OPTIONS is correct (private API usage)'(assert) { | |||
There was a problem hiding this comment.
We don't need this test anymore.
glimmerjs/glimmer-vm#1535
From the implementation notes:
/*
Internet Explorer 11 does not support `once` and also does not support
passing `eventOptions`. In some situations it then throws a weird script
error, like:
```
Could not complete the operation due to error 80020101
```
This flag determines, whether `{ once: true }` and thus also event options in
general are supported.
*/
NullVoxPopuli
changed the title
|
This is now passing after I removed ts@next. The PR will still show that as an expected check and I don't think you can fix that without reopening the PR, so I'm just going to ignore that check. |
chriskrycho
reviewed
Jan 9, 2024
Comment on lines
+61
to
+63
| // SAFETY: `get` could not infer the type of `prop` and just gave us `unknown`. | ||
| // we may want to throw an error in the future if the value isn't string or null/undefined. | ||
| let elementId = get(component, prop) as string | null; |
There was a problem hiding this comment.
N.b. the right way to do this is to use a dev-time assert() that is stripped in prod builds instead!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains some perf improvements as well as a memory leak fix for a feature we introduced in 3.25, described here: https://guides.emberjs.com/release/in-depth-topics/rendering-values/
Here is the changelog: https://github.com/glimmerjs/glimmer-vm/releases/tag/v0.86.0