Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm pack to include js files #1408

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Fix npm pack to include js files #1408

merged 1 commit into from
Jun 9, 2023
+7 −4

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Jun 9, 2023 •
edited
Loading

To get CI green, this needs to be merged: #1406

Resolves #1402

Previously, both npm pack and yarn pack would not include the js files.
This change makes it so that the js files are included in the tarball.

It's possible this is fallout from v2 conversion part 1, where the repo was split in to a monorepo, as the .gitignore was left in the monorepo root, and not.
(I expected v2 conversion of all 3 test projects to be < 1 month, so... my expectations are probably to blame here.....)

The contents of `npm pack`'s tarball: 
"
package/README.md
package/addon-test-support/@ember/test-helpers/-internal/build-registry.js
package/addon-test-support/@ember/test-helpers/-internal/build-registry.ts
package/addon-test-support/@ember/test-helpers/-internal/debug-info-helpers.js
package/addon-test-support/@ember/test-helpers/-internal/debug-info-helpers.ts
package/addon-test-support/@ember/test-helpers/-internal/debug-info.js
package/addon-test-support/@ember/test-helpers/-internal/debug-info.ts
package/addon-test-support/@ember/test-helpers/-internal/deprecations.js
package/addon-test-support/@ember/test-helpers/-internal/deprecations.ts
package/addon-test-support/@ember/test-helpers/-internal/is-component.js
package/addon-test-support/@ember/test-helpers/-internal/is-component.ts
package/addon-test-support/@ember/test-helpers/-internal/is-promise.js
package/addon-test-support/@ember/test-helpers/-internal/is-promise.ts
package/addon-test-support/@ember/test-helpers/-internal/render-settled.js
package/addon-test-support/@ember/test-helpers/-internal/render-settled.ts
package/addon-test-support/@ember/test-helpers/-internal/warnings.js
package/addon-test-support/@ember/test-helpers/-internal/warnings.ts
package/addon-test-support/@ember/test-helpers/-tuple.js
package/addon-test-support/@ember/test-helpers/-tuple.ts
package/addon-test-support/@ember/test-helpers/-utils.js
package/addon-test-support/@ember/test-helpers/-utils.ts
package/addon-test-support/@ember/test-helpers/application.js
package/addon-test-support/@ember/test-helpers/application.ts
package/addon-test-support/@ember/test-helpers/build-owner.js
package/addon-test-support/@ember/test-helpers/build-owner.ts
package/addon-test-support/@ember/test-helpers/dom/-get-element.js
package/addon-test-support/@ember/test-helpers/dom/-get-element.ts
package/addon-test-support/@ember/test-helpers/dom/-get-elements.js
package/addon-test-support/@ember/test-helpers/dom/-get-elements.ts
package/addon-test-support/@ember/test-helpers/dom/-get-window-or-element.js
package/addon-test-support/@ember/test-helpers/dom/-get-window-or-element.ts
package/addon-test-support/@ember/test-helpers/dom/-guard-for-maxlength.js
package/addon-test-support/@ember/test-helpers/dom/-guard-for-maxlength.ts
package/addon-test-support/@ember/test-helpers/dom/-is-focusable.js
package/addon-test-support/@ember/test-helpers/dom/-is-focusable.ts
package/addon-test-support/@ember/test-helpers/dom/-is-form-control.js
package/addon-test-support/@ember/test-helpers/dom/-is-form-control.ts
package/addon-test-support/@ember/test-helpers/dom/-is-select-element.js
package/addon-test-support/@ember/test-helpers/dom/-is-select-element.ts
package/addon-test-support/@ember/test-helpers/dom/-logging.js
package/addon-test-support/@ember/test-helpers/dom/-logging.ts
package/addon-test-support/@ember/test-helpers/dom/-target.js
package/addon-test-support/@ember/test-helpers/dom/-target.ts
package/addon-test-support/@ember/test-helpers/dom/-to-array.js
package/addon-test-support/@ember/test-helpers/dom/-to-array.ts
package/addon-test-support/@ember/test-helpers/dom/blur.js
package/addon-test-support/@ember/test-helpers/dom/blur.ts
package/addon-test-support/@ember/test-helpers/dom/click.js
package/addon-test-support/@ember/test-helpers/dom/click.ts
package/addon-test-support/@ember/test-helpers/dom/double-click.js
package/addon-test-support/@ember/test-helpers/dom/double-click.ts
package/addon-test-support/@ember/test-helpers/dom/fill-in.js
package/addon-test-support/@ember/test-helpers/dom/fill-in.ts
package/addon-test-support/@ember/test-helpers/dom/find-all.js
package/addon-test-support/@ember/test-helpers/dom/find-all.ts
package/addon-test-support/@ember/test-helpers/dom/find.js
package/addon-test-support/@ember/test-helpers/dom/find.ts
package/addon-test-support/@ember/test-helpers/dom/fire-event.js
package/addon-test-support/@ember/test-helpers/dom/fire-event.ts
package/addon-test-support/@ember/test-helpers/dom/focus.js
package/addon-test-support/@ember/test-helpers/dom/focus.ts
package/addon-test-support/@ember/test-helpers/dom/get-root-element.js
package/addon-test-support/@ember/test-helpers/dom/get-root-element.ts
package/addon-test-support/@ember/test-helpers/dom/scroll-to.js
package/addon-test-support/@ember/test-helpers/dom/scroll-to.ts
package/addon-test-support/@ember/test-helpers/dom/select.js
package/addon-test-support/@ember/test-helpers/dom/select.ts
package/addon-test-support/@ember/test-helpers/dom/tab.js
package/addon-test-support/@ember/test-helpers/dom/tab.ts
package/addon-test-support/@ember/test-helpers/dom/tap.js
package/addon-test-support/@ember/test-helpers/dom/tap.ts
package/addon-test-support/@ember/test-helpers/dom/trigger-event.js
package/addon-test-support/@ember/test-helpers/dom/trigger-event.ts
package/addon-test-support/@ember/test-helpers/dom/trigger-key-event.js
package/addon-test-support/@ember/test-helpers/dom/trigger-key-event.ts
package/addon-test-support/@ember/test-helpers/dom/type-in.js
package/addon-test-support/@ember/test-helpers/dom/type-in.ts
package/addon-test-support/@ember/test-helpers/dom/wait-for.js
package/addon-test-support/@ember/test-helpers/dom/wait-for.ts
package/addon-test-support/@ember/test-helpers/global.js
package/addon-test-support/@ember/test-helpers/global.ts
package/addon-test-support/@ember/test-helpers/has-ember-version.js
package/addon-test-support/@ember/test-helpers/has-ember-version.ts
package/addon-test-support/@ember/test-helpers/helper-hooks.js
package/addon-test-support/@ember/test-helpers/helper-hooks.ts
package/addon-test-support/@ember/test-helpers/index.js
package/addon-test-support/@ember/test-helpers/index.ts
package/addon-test-support/@ember/test-helpers/rerender.js
package/addon-test-support/@ember/test-helpers/rerender.ts
package/addon-test-support/@ember/test-helpers/resolver.js
package/addon-test-support/@ember/test-helpers/resolver.ts
package/addon-test-support/@ember/test-helpers/settled.js
package/addon-test-support/@ember/test-helpers/settled.ts
package/addon-test-support/@ember/test-helpers/setup-application-context.js
package/addon-test-support/@ember/test-helpers/setup-application-context.ts
package/addon-test-support/@ember/test-helpers/setup-context.js
package/addon-test-support/@ember/test-helpers/setup-context.ts
package/addon-test-support/@ember/test-helpers/setup-onerror.js
package/addon-test-support/@ember/test-helpers/setup-onerror.ts
package/addon-test-support/@ember/test-helpers/setup-rendering-context.js
package/addon-test-support/@ember/test-helpers/setup-rendering-context.ts
package/addon-test-support/@ember/test-helpers/teardown-context.js
package/addon-test-support/@ember/test-helpers/teardown-context.ts
package/addon-test-support/@ember/test-helpers/test-metadata.js
package/addon-test-support/@ember/test-helpers/test-metadata.ts
package/addon-test-support/@ember/test-helpers/validate-error-handler.js
package/addon-test-support/@ember/test-helpers/validate-error-handler.ts
package/addon-test-support/@ember/test-helpers/wait-until.js
package/addon-test-support/@ember/test-helpers/wait-until.ts
package/dist-types/-internal/build-registry.d.ts
package/dist-types/-internal/build-registry.d.ts.map
package/dist-types/-internal/debug-info-helpers.d.ts
package/dist-types/-internal/debug-info-helpers.d.ts.map
package/dist-types/-internal/debug-info.d.ts
package/dist-types/-internal/debug-info.d.ts.map
package/dist-types/-internal/deprecations.d.ts
package/dist-types/-internal/deprecations.d.ts.map
package/dist-types/-internal/is-component.d.ts
package/dist-types/-internal/is-component.d.ts.map
package/dist-types/-internal/is-promise.d.ts
package/dist-types/-internal/is-promise.d.ts.map
package/dist-types/-internal/render-settled.d.ts
package/dist-types/-internal/render-settled.d.ts.map
package/dist-types/-internal/warnings.d.ts
package/dist-types/-internal/warnings.d.ts.map
package/dist-types/-tuple.d.ts
package/dist-types/-tuple.d.ts.map
package/dist-types/-utils.d.ts
package/dist-types/-utils.d.ts.map
package/dist-types/application.d.ts
package/dist-types/application.d.ts.map
package/dist-types/build-owner.d.ts
package/dist-types/build-owner.d.ts.map
package/dist-types/dom/-get-element.d.ts
package/dist-types/dom/-get-element.d.ts.map
package/dist-types/dom/-get-elements.d.ts
package/dist-types/dom/-get-elements.d.ts.map
package/dist-types/dom/-get-window-or-element.d.ts
package/dist-types/dom/-get-window-or-element.d.ts.map
package/dist-types/dom/-guard-for-maxlength.d.ts
package/dist-types/dom/-guard-for-maxlength.d.ts.map
package/dist-types/dom/-is-focusable.d.ts
package/dist-types/dom/-is-focusable.d.ts.map
package/dist-types/dom/-is-form-control.d.ts
package/dist-types/dom/-is-form-control.d.ts.map
package/dist-types/dom/-is-select-element.d.ts
package/dist-types/dom/-is-select-element.d.ts.map
package/dist-types/dom/-logging.d.ts
package/dist-types/dom/-logging.d.ts.map
package/dist-types/dom/-target.d.ts
package/dist-types/dom/-target.d.ts.map
package/dist-types/dom/-to-array.d.ts
package/dist-types/dom/-to-array.d.ts.map
package/dist-types/dom/blur.d.ts
package/dist-types/dom/blur.d.ts.map
package/dist-types/dom/click.d.ts
package/dist-types/dom/click.d.ts.map
package/dist-types/dom/double-click.d.ts
package/dist-types/dom/double-click.d.ts.map
package/dist-types/dom/fill-in.d.ts
package/dist-types/dom/fill-in.d.ts.map
package/dist-types/dom/find-all.d.ts
package/dist-types/dom/find-all.d.ts.map
package/dist-types/dom/find.d.ts
package/dist-types/dom/find.d.ts.map
package/dist-types/dom/fire-event.d.ts
package/dist-types/dom/fire-event.d.ts.map
package/dist-types/dom/focus.d.ts
package/dist-types/dom/focus.d.ts.map
package/dist-types/dom/get-root-element.d.ts
package/dist-types/dom/get-root-element.d.ts.map
package/dist-types/dom/scroll-to.d.ts
package/dist-types/dom/scroll-to.d.ts.map
package/dist-types/dom/select.d.ts
package/dist-types/dom/select.d.ts.map
package/dist-types/dom/tab.d.ts
package/dist-types/dom/tab.d.ts.map
package/dist-types/dom/tap.d.ts
package/dist-types/dom/tap.d.ts.map
package/dist-types/dom/trigger-event.d.ts
package/dist-types/dom/trigger-event.d.ts.map
package/dist-types/dom/trigger-key-event.d.ts
package/dist-types/dom/trigger-key-event.d.ts.map
package/dist-types/dom/type-in.d.ts
package/dist-types/dom/type-in.d.ts.map
package/dist-types/dom/wait-for.d.ts
package/dist-types/dom/wait-for.d.ts.map
package/dist-types/global.d.ts
package/dist-types/global.d.ts.map
package/dist-types/has-ember-version.d.ts
package/dist-types/has-ember-version.d.ts.map
package/dist-types/helper-hooks.d.ts
package/dist-types/helper-hooks.d.ts.map
package/dist-types/index.d.ts
package/dist-types/index.d.ts.map
package/dist-types/rerender.d.ts
package/dist-types/rerender.d.ts.map
package/dist-types/resolver.d.ts
package/dist-types/resolver.d.ts.map
package/dist-types/settled.d.ts
package/dist-types/settled.d.ts.map
package/dist-types/setup-application-context.d.ts
package/dist-types/setup-application-context.d.ts.map
package/dist-types/setup-context.d.ts
package/dist-types/setup-context.d.ts.map
package/dist-types/setup-onerror.d.ts
package/dist-types/setup-onerror.d.ts.map
package/dist-types/setup-rendering-context.d.ts
package/dist-types/setup-rendering-context.d.ts.map
package/dist-types/teardown-context.d.ts
package/dist-types/teardown-context.d.ts.map
package/dist-types/test-metadata.d.ts
package/dist-types/test-metadata.d.ts.map
package/dist-types/validate-error-handler.d.ts
package/dist-types/validate-error-handler.d.ts.map
package/dist-types/wait-until.d.ts
package/dist-types/wait-until.d.ts.map
package/index.js
package/package.json
package/type-tests/api.ts
package/type-tests/tsconfig.json
package/types.tsconfig.json"

@NullVoxPopuli
Fix npm pack to include js files

Verified

This commit was signed with the committer’s verified signature.
chriskrycho Chris Krycho
GPG key ID: FA77559C18FE8A08
Verified
Learn about vigilant mode
b96445b
@NullVoxPopuli NullVoxPopuli mentioned this pull request Jun 9, 2023
Closed
@MelSumner MelSumner merged commit 4fc6475 into emberjs:master Jun 9, 2023
@MelSumner MelSumner mentioned this pull request Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MelSumner MelSumner

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anomalies in current published version compared to previous versions
2 participants
@NullVoxPopuli @MelSumner