fixing the release

[MelSumner]

in #1397 a user has reported that types are missing and they are getting an error.

This PR updates the .npmignore file and the package.json file to more correctly reflect what should be getting published re:types.

This error seems to be related to the differences between npm pack and yarn pack.

Also not 100% sure this will be the fix but thanks to @gitKrystan @chriskrycho and @NullVoxPopuli for working through this toward a potential solution.

[MelSumner]

Ok it does seem like there are some undocumented pre-publish steps; working on a new release now. This reversion isn't necessary so I'm closing the PR.

[MelSumner]

so I tried running some of the scripts in the package.json and re-publish, but that didn't seem to fix it either, so looks like we might need to revert the .npmignore change after all.

[gitKrystan]

Looking into this. I think we need something like this in package.json:

https://github.com/emberjs/ember.js/blob/87c7fc72a3112936ae701a6768072d31caf4730d/package.json#LL173C3-L182C5

[MelSumner]

@gitKrystan so would that replace what's in there now?

"typesVersions": {
    "*": {
      "*": [
        "public-types/@ember/test-helpers/*"
      ]
    }
  },

[NullVoxPopuli]

@MelSumner public-types are emitted via: https://github.com/emberjs/ember-test-helpers/blob/master/addon/types.tsconfig.json#L7

but the prepack command should have included that: https://github.com/emberjs/ember-test-helpers/blob/master/addon/package.json#L29 🤔

[gitKrystan]

Looks like it should be:

  "typesVersions": {
    "*": {
      "*": [
        "public-types/*"
      ]
    }
  }

However, I'm not sure what will force the public-types folder to be included in the published package.

I was able to confirm that 3.0 does not currently include the public-types folder but I'm not able to reproduce that locally (using yalc) so I'm scared to guarantee that the above change will fix everything. I was, however, able to confirm that the typesVersions config was wrong and that the above is correct.

[MelSumner]

@gitKrystan @chriskrycho there was a tiny variation between both of your suggestions, should it be ./public-types/* or public-types/*?

[gitKrystan]

Either should work. (Confirmed both of them locally just to be sure.)

[MelSumner]

So even with these changes, I'm still not seeing the public_types folder when I run npm pack locally. 🤔

[MelSumner]

Changing to dist-types from public-types seems to resolve the issue, in that I now get it locally when I run npm pack to check. But...why? makes no real logical sense. Why would it work before but not now? 🤔