Add useAt option to autofix .lastObject to .at(-1) in no-get rule
#1847
+126
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
changed the title
.lastObject to .at(-1) in no-get rule
|
This is a nice improvement. However, I don't think we can make this the default behavior until Node 16 becomes end-of-life in Sept, 2023. We could put this behind an option https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/at |
|
@bmish Thanks for the advice. I'd assume the default value of |
|
We need to keep this feature turned off by default until we drop the corresponding Node version support. So |
ArtixZ
force-pushed
the
donzhu/no-get-lastObject-improvement
branch
from
511e895 to
63e0286
Compare
bmish
reviewed
May 18, 2023
|
Looking forward to seeing this get in still! It's nearly finished. |
|
Sorry I was sidetracked by other stuff. Will have an update today. |
Closed
bmish
changed the title
.lastObject to .at(-1) in no-get ruleuseAt option to autofix .lastObject to .at(-1) in no-get rule
bmish
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.lastObjectautofix rule can be simplified as.lastObject==>.at(-1).We can lift the limit of handling only one
.lastObjectin path as well.