Fix crash with no-tracked-properties-from-args rule
#1712
Merged
+32
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
reviewed
Dec 20, 2022
| node.value.object?.type === 'MemberExpression' && | ||
| node.value.object?.object.type === 'ThisExpression' && | ||
| node.value.object?.property.name === 'args'; | ||
| node.value?.object?.type === 'MemberExpression' && |
There was a problem hiding this comment.
Normally, it's better practice to be checking the type of the nodes we're dealing with, instead of just checking that various properties exist. Can we check the type on node and node.value before attempting to use them?
There was a problem hiding this comment.
Some really useful helpers and examples already built-ini I just needed to track down, thanks!
|
Looks like you need to rebase on master, lots of extra commits. |
bmish
reviewed
Dec 21, 2022
bmish
changed the title
no-tracked-properties-from-args rule
bmish
approved these changes
Dec 21, 2022
rtablada
pushed a commit
to rtablada/eslint-plugin-ember
that referenced
this pull request
Dec 30, 2022
Co-authored-by: Joan Cejudo <joan@Joans-MacBook-Pro.local> Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com> Fixes ember-cli#1711
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1711