Don't lose optional chaining with objectAt
in autofix for no-array-prototype-extensions
rule
#1687
+14
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add optional chaining support to
objectAt
auto-fixer.Detail
Right now the
objectAt
auto-fixer in no-array-prototype-extensions will remove the optional chaining operator(?.). So this PR will usecallExpressionNode.callee.optional
to check the optional chaining use case and keep the optional chaining operator.For example, the following template
const response = this.demoResponses?.objectAt(questionIndex);
Before:
const response = this.demoResponses[questionIndex];
After:
const response = this.demoResponses?.[questionIndex];
Testing Done
Add two new test cases to check the optional chaining use case.
All test cases passed.