Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uniqBy to reduce autofixer for no-array-prototype-extensions rule #1626

Merged
merged 4 commits into from
Oct 11, 2022

Conversation

tgvrssanthosh
Copy link
Contributor

Summary

Added auto-fixer for no-array-prototype-extensions which replaces uniqBy with reduce.

Description

Recently, the proposal to deprecate array prototype extensions has been approved and got merged. The plan is to add autoFixers to replace ember array prototype extensions with the native array methods. In this PR, an auto fixer has been added which will replace the ember array method uniqBy with the native array method reduce.

Testing

Modified test case to check if the right output is generated after the fix.

@tgvrssanthosh tgvrssanthosh marked this pull request as ready for review October 10, 2022 17:00
@tgvrssanthosh
Copy link
Contributor Author

@bmish Can you help review this PR?

@tgvrssanthosh
Copy link
Contributor Author

@bmish Addressed your comments. Please take a relook. Thank you!

Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This autofix output is a bit complicated -- maybe we can follow-up to improve that if a simpler solution becomes available.

@bmish bmish merged commit 2075e67 into ember-cli:master Oct 11, 2022
@tgvrssanthosh
Copy link
Contributor Author

Thanks! This autofix output is a bit complicated -- maybe we can follow up to improve that if a simpler solution becomes available.

Agreed. It looks a bit complex. We might have to revisit this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants