Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add objectAt autofixer for no-array-prototype-extensions rule #1615

Merged
merged 4 commits into from
Oct 7, 2022

Conversation

tgvrssanthosh
Copy link
Contributor

Summary

Added auto-fixer for no-array-prototype-extensions which fixes the objectAt usage.

Description

Recently, the proposal to deprecate array prototype extensions has been approved and got merged. The plan is to add autoFixers to replace ember array prototype extensions with the native array methods. In this PR, an auto fixer has been added which will fix the usage of objectAt method.

Testing

Modified test case to check if the right output is generated after the fix.

Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmish bmish merged commit e242463 into ember-cli:master Oct 7, 2022
@tgvrssanthosh tgvrssanthosh deleted the autoFix-objectAt branch October 7, 2022 15:01
@bmish bmish changed the title Add objectAt autofixer for no-array-prototype-extensions rule Add objectAt autofixer for no-array-prototype-extensions rule Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants