Add findBy to find autofixer for no-array-prototype-extensions rule
#1614
+107
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bmish Can you please review this PR as well? Thank you! |
bmish
changed the title
findBy to find auto-fixer for no-array-prototype-extensions rulefindBy to find autofixer for no-array-prototype-extensions rule
bmish
reviewed
Oct 7, 2022
|
Can you also merge master in? There were some dependency updates merged recently. |
Just rebased the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added auto-fixer for
no-array-prototype-extensionswhich replacesfindBywithfind.Description
Recently, the proposal to deprecate array prototype extensions has been approved and got merged. The plan is to add autoFixers to replace ember array prototype extensions with the native array methods. In this PR, an auto fixer has been added which will replace the ember array method
findBywith the native array methodfind.Testing
Modified test case to check if the right output is generated after the fix.