Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to deprecation RFC in no-array-prototype-extensions rule doc #1582

Merged

Conversation

bmish
Copy link
Member

@bmish bmish commented Sep 1, 2022

TODO: update from RFC PR to actual RFC link once merged.

CC: @smilland

@smilland
Copy link
Contributor

smilland commented Sep 30, 2022

RFC was merged! emberjs/rfcs#848, feel free to merge this PR. Thank you @bmish!

@lin-ll
Copy link
Collaborator

lin-ll commented Sep 30, 2022

Awesome! Let's update that link from the PR to the actual RFC link: https://rfcs.emberjs.com/id/0848-deprecate-array-prototype-extensions
And then we'll merge it in! :)
(I can do this later today if we're not in a rush)

Thanks for your hard work on the RFC, @smilland !

@lin-ll lin-ll merged commit 3ecebfb into ember-cli:master Oct 1, 2022
@bmish
Copy link
Member Author

bmish commented Oct 1, 2022

Thanks for finishing this up @lin-ll!

@smilland
Copy link
Contributor

smilland commented Oct 4, 2022

thank you @lin-ll !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants