Update to deploy to the master branch and also correct a comment #10405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the docs script to deploy directly to the
masterbranch ofember-learn/ember-cli.github.iowhen an ember-cli version is tagged. This has been tested by deploying totest-docs-deployin that same repohttps://github.com/ember-cli/ember-cli/actions/runs/6829056476
https://github.com/ember-learn/ember-cli.github.io/tree/test-deploy-docs
This script has a slight problem at the moment in that if we tag a point release for an older version, it will clobber the newer docs. For now, I am satisfied that that is very rare and we can always fix it by manually triggering the workflow for the newer semver version.
cc @mansona