[ENHANCEMENT] automatically select a port by default with ember serve
#10394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sportshead
changed the title
ember serveember serve
| return command.validateAndRun().then(function () { | ||
| let captor = td.matchers.captor(); | ||
| td.verify(tasks.Serve.prototype.run(captor.capture()), {times: 1}); | ||
| expect(captor.value.port).to.be.within(4201, 65535, 'has correct port'); |
NullVoxPopuli
approved these changes
Oct 27, 2023
sportshead
commented
Oct 27, 2023
|
I'll also make a patch to fix the test and lint errors |
|
@sportshead this is looking good -- can you get the tests passing? <3 |
|
@NullVoxPopuli - all the failed tests are referring to |
|
the help output shows the description for the flags, so since the |
Fixes #9512 The base port has also been changed from 7020 (which seems to have been arbitrarily chosen in 43878e2) to 4200, the current default. The old value of 7020 also doesn't seem to do anything since it's overridden by the default 4200 anyways. The `should throw error when -p PORT is taken` test block has been moved out of a legacy if statement referencing appveyor. Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
|
@NullVoxPopuli ah, that makes sense. I've updated the PR with the new changes for the help tests. |
NullVoxPopuli
approved these changes
Oct 31, 2023
sportshead
added a commit
to sportshead/cli-guides
that referenced
this pull request
Nov 1, 2023
See ember-cli/ember-cli#10394 Also fixed some of the line wrapping in other parts of the `ember serve` help text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9512
ember servewill now automatically choose a port (starting with 4200), unless a port is explicitly set with the--portflag or the$PORTenv variable.Notes:
The base port has also been changed from 7020 (which seems to have been arbitrarily chosen in 43878e2) to 4200, the current default. The old value of 7020 also doesn't seem to do anything since it's overridden by the default 4200 anyways.
The
should throw error when -p PORT is takentest block has been moved out of a legacy if statement referencing appveyor.