Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] feat: add skip-install alias to skip-npm #10393

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

IgnaceMaes
Copy link
Contributor

The --skip-npm flag seems rather confusing now that three package managers are supported.

e.g. a valid way to generate an Ember app with pnpm today is:

ember new example-app --pnpm --skip-npm

With this alias it could be written as follows:

ember new example-app --pnpm --skip-install

I don't have a lot of context about the impact of this change, so please let me know if it isn't as simple as just adding an alias 馃槃

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- do we have any docs/guides pages that need updated as well?

@IgnaceMaes
Copy link
Contributor Author

There doesn't appear to be any references in the guides.

In the cli docs there are three references for which I opened a PR here: ember-learn/cli-guides#308

@kategengler kategengler merged commit c29ad5b into ember-cli:master Oct 27, 2023
11 checks passed
@kategengler
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants