remove duplicate execute_ddl, @impl true, table prefixes #103
+62
−199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
commented
Feb 17, 2023
|
|
||
| assert execute_ddl(create) == [ | ||
| """ | ||
| CREATE INDEX "posts_category_id_permalink_index" \ | ||
| ON "foo"."posts" ("category_id", "permalink")\ | ||
| ON "posts" ("category_id", "permalink")\ |
There was a problem hiding this comment.
Since the test is about comments, I just removed the prefix option here.
ruslandoga
changed the title
ruslandoga
changed the title
warmwaffles
reviewed
Feb 17, 2023
|
|
||
| assert execute_ddl(create) == [ | ||
| """ | ||
| CREATE INDEX "posts_category_id_permalink_index" \ | ||
| ON "foo"."posts" ("category_id", "permalink")\ | ||
| ON "posts" ("category_id", "permalink")\ |
warmwaffles
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
@ruslandoga can you add an entry to the changelog as well about this change? We have an unreleased section with some breaking changes that I'll roll this into a 1.0 release as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #102