Skip to content

Missing literal, selected_as and using CAST for floats. #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

jeregrine
Copy link
Contributor

I was playing around some queries and noticed literals and selected_as was not implemented.

I also saw the comment about being unsure about floats so I just read the guide and it has CAST as if we know the type. I chose REAL but it looks like FLOAT would also work LMK if you think I should change it.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jeregrine
Copy link
Contributor Author

jeregrine commented Jan 20, 2023

FYI @josevalim has convinced me to try and port the current postgres/mysql connection tests to current sqlite since they appear to be an original fork from the first time this was tried. I won't include that here but something to keep in mind.

@warmwaffles warmwaffles merged commit 2e8e1a9 into elixir-sqlite:main Jan 20, 2023
@warmwaffles
Copy link
Member

warmwaffles commented Jan 20, 2023

has convinced me to try and port the current postgres/mysql connection tests to current sqlite since they appear to be an original fork from the first time this was tried.

@jeregrine that would be awesome! I will not say no to fixes and more tests 😄

@jeregrine
Copy link
Contributor Author

I have a small WIP where I copied the postgres connection tests over to this repo from ecto_sql and ported them. I put a bunch of TODO in places we should probably raise.

And for sure missed some others from the connection test you added in addition to the postgres specific tests.

https://github.com/elixir-sqlite/ecto_sqlite3/compare/main...jeregrine:js/pg-connection-test?expand=1

@warmwaffles
Copy link
Member

I missed that the JSON type with strict mode that we are wanting to enforce is not a valid type.

@jeregrine
Copy link
Contributor Author

haha you're all good, sqlite is super permissive haha.

@warmwaffles
Copy link
Member

sqlite is super permissive

Which is why I didn't initially jump on the strict typing. I liked the flexibility, but it's probably smarter to be more strict.

@jeregrine
Copy link
Contributor Author

#101 discussion here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants