Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure nextest to run database tests serially #3809

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

sandhose
Copy link
Member

@sandhose sandhose commented Jan 20, 2025

This should resolve the flakes we're regularly seeing in CI by running all the database tests serially.
To avoid getting too much of a speed penalty, I've also added another shard to the test runs in CI

This is necessary until launchbadge/sqlx#3334 gets merged

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

cloudflare-workers-and-pages bot commented Jan 20, 2025

Deploying matrix-authentication-service-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6698759
Status: ✅  Deploy successful!
Preview URL: https://f881d8a0.matrix-authentication-service-docs.pages.dev
Branch Preview URL: https://quenting-nextest-database-se.matrix-authentication-service-docs.pages.dev

View logs

@sandhose sandhose requested a review from reivilibre January 20, 2025 09:10
Copy link
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, seems like nextest has some nice flexibility

@sandhose sandhose merged commit ab23d1a into main Jan 20, 2025
21 checks passed
@sandhose sandhose deleted the quenting/nextest-database-serial branch January 20, 2025 09:56
@sandhose sandhose added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants