Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the Docker image has the git version in it #3715

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

sandhose
Copy link
Member

@sandhose sandhose commented Dec 18, 2024

#3671 did not work with the Docker image, as we did not have the .git directory at build time

Copy link

cloudflare-workers-and-pages bot commented Dec 18, 2024

Deploying matrix-authentication-service-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0b535eb
Status: ✅  Deploy successful!
Preview URL: https://69f12f3c.matrix-authentication-service-docs.pages.dev
Branch Preview URL: https://quenting-version-in-docker.matrix-authentication-service-docs.pages.dev

View logs

@sandhose sandhose force-pushed the quenting/version-in-docker branch from c60d6b3 to 67fa77f Compare December 18, 2024 17:54

Verified

This commit was signed with the committer’s verified signature.
sandhose Quentin Gliech
@sandhose sandhose force-pushed the quenting/version-in-docker branch from 67fa77f to 0b535eb Compare December 18, 2024 17:57
@sandhose sandhose requested a review from reivilibre December 18, 2024 17:58
@sandhose sandhose merged commit bc102c3 into main Jan 6, 2025
23 checks passed
@sandhose sandhose deleted the quenting/version-in-docker branch January 6, 2025 09:13
@sandhose sandhose added A-Container Related to the Docker container T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Container Related to the Docker container T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants