Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow response_mode to be null and if so do not add the query param #3700

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

MatMaul
Copy link
Contributor

@MatMaul MatMaul commented Dec 17, 2024

No description provided.

@MatMaul MatMaul force-pushed the response-mode-default branch from fdd796d to 8c59ebe Compare December 17, 2024 10:59
Copy link
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few style points, otherwise looks good!

MatMaul and others added 5 commits December 18, 2024 12:26
Fix
Fix
@MatMaul MatMaul requested a review from sandhose December 18, 2024 17:07
@sandhose sandhose merged commit af1282b into element-hq:main Dec 18, 2024
18 checks passed
@sandhose sandhose added A-Upstream-OAuth Related to login via upstream OAuth 2.0 providers T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Upstream-OAuth Related to login via upstream OAuth 2.0 providers T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants