Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when a translation file fails to load #3684

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

sandhose
Copy link
Member

@sandhose sandhose commented Dec 13, 2024

We had invalid translations (in #3682 for example) but the error message wouldn't say which file exactly. This adds the path to the file being loaded in the error, making it easier to debug.

Copy link

cloudflare-workers-and-pages bot commented Dec 13, 2024

Deploying matrix-authentication-service-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c7acee4
Status: ✅  Deploy successful!
Preview URL: https://feed34c4.matrix-authentication-service-docs.pages.dev
Branch Preview URL: https://quenting-translation-loading.matrix-authentication-service-docs.pages.dev

View logs

@sandhose sandhose requested a review from reivilibre December 16, 2024 14:59
@sandhose sandhose merged commit b690542 into main Dec 16, 2024
19 checks passed
@sandhose sandhose deleted the quenting/translation-loading-error branch December 16, 2024 16:39
@sandhose sandhose added A-Configuration Related on what is configurable and how it can be configured A-I18n Area: Internationalization T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Configuration Related on what is configurable and how it can be configured A-I18n Area: Internationalization T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants