Make sure refreshing OAuth token is idempotent #3650
Merged
+672
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
e64e5f5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7a059f05.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-refresh-idempotence.matrix-authentication-service-docs.pages.dev |
This will help us determine whether we had a double-refresh happening
If we continue deleting expired tokens, we might not record whether the token was used or not, and not know what to do in case of a double-refresh. Revoked tokens are safe to delete. This also reduces the frequency of the cleanup job to once an hour.
This lets us track 'revoked' tokens separately from 'consumed' tokens.
This allows using a refresh token multiple times, as long as the new pair of tokens were not used in the meantime.
sandhose
force-pushed
the
quenting/refresh-idempotence
branch
from
89331a3 to
76137c4
Compare
reivilibre
approved these changes
Dec 11, 2024
| &state.clock, | ||
| &mut repo, | ||
| &session, | ||
| Duration::microseconds(5 * 60 * 1000 * 1000), |
There was a problem hiding this comment.
is there really no way to do Duration::seconds(5 * 60) lol? :D
There was a problem hiding this comment.
I think it's the only one that can't panic, and clippy will complain that we don't document that potential panic I think? 😬
|
('idempotent' seems like a misleading word since the old tokens get revoked, rather than returned again, but not sure if there's a more accurate word that matches it better) |
Co-authored-by: reivilibre <oliverw@element.io>
This was referenced Dec 11, 2024
sandhose
added
T-Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2795
This can be reviewed commit by commit
It is basically: