Allow setting an explicit upstream account name #3600
Merged
+302
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
6c10e68
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://646942a3.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-upstream-oauth-acco.matrix-authentication-service-docs.pages.dev |
sandhose
added
the
A-Upstream-OAuth
reivilibre
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow setting an explicit "account name" for the upstream accounts, as the email address is not always the same as the account name.
This also tweaks some designs to match the latest Figmas.
I'll do a pass later for documentation, as we have a bunch of new options on the upstream OAuth 2.0 providers config, and would like to fit that in a demo