Load the Intl.Segmenter and Intl.DurationFormat polyfills only if needed #2778
+60
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandhose
force-pushed
the
quenting/lazy-load-polyfills
branch
from
6492ce0 to
ab3a322
Compare
sandhose
changed the title
Half-Shot
reviewed
Nov 14, 2024
| import { useTranslation } from "react-i18next"; | ||
|
|
||
| import { ReactionIndicator } from "./ReactionIndicator"; | ||
|
|
||
| const durationFormatter = new DurationFormat(undefined, { | ||
| const durationFormatter = new Intl.DurationFormat(undefined, { |
There was a problem hiding this comment.
This landed in Node 23, so we will need to polyfill the tests.
There was a problem hiding this comment.
Fixed! I also had to embed the translations in tests, as now the initializer waits for i18next to initialise now before continuing
There was a problem hiding this comment.
Oh but your polyfill code should actually be doing this, ugh??
There was a problem hiding this comment.
initializeBeforeReact isn't necessarily being run in tests
sandhose
force-pushed
the
quenting/lazy-load-polyfills
branch
from
f54bfa8 to
80bac32
Compare
hughns
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes around 200Kb of the main bundle.
It will still load the polyfill if needed (notably the previous Firefox ESR), but skips on modern browsers.