New one-on-one layout #2417
New one-on-one layout #2417
Conversation
robintown
force-pushed
the
one-on-one-layout
branch
from
46935bd to
54198d6
Compare
|
TODO: If you switch to spotlight while connecting, the app crashes |
robintown
force-pushed
the
one-on-one-layout
branch
from
54198d6 to
17d0cdd
Compare
robintown
force-pushed
the
one-on-one-layout
branch
2 times, most recently
from
ae4fe68 to
aa389d0
Compare
robintown
force-pushed
the
one-on-one-layout
branch
from
aa389d0 to
7ec04fe
Compare
Because we were hiding even the local participant during initial connection, there would be no participants, and therefore nothing to put in the spotlight. The designs don't really tell us what the connecting state should look like, so I've taken the liberty of restoring it to its former glory of showing the local participant immediately.
robintown
force-pushed
the
one-on-one-layout
branch
from
7ec04fe to
a16f235
Compare
There was a problem hiding this comment.
This looks good.
I might have missed it but as far as i can tell this does never render tiles in portrait mode.
I think in 1:1 that is the one situation where this is totally doable.
I think right now it behaves the other way around which is already great (landscape will be rendered as landscape on a portrait screen).
But portrait media being rendered as portrait on a landscape screen would also be nice. (maybe with a little bit of a cutoff to not make it too small 9:16 becomeing 2:3 or similar)
| > | ||
| <Slot | ||
| className={classNames(styles.slot, styles.local)} | ||
| id={localTileModel.vm.id} | ||
| model={localTileModel} | ||
| onDrag={onDragLocalTile} | ||
| data-block-alignment={pipAlignmentValue.block} | ||
| data-inline-alignment={pipAlignmentValue.inline} | ||
| /> | ||
| </Slot> |
There was a problem hiding this comment.
Interesting. The slot for the local media feed is a child of the remote participant slot?
That makes actually.
So the local tile is always inside the parent/remote tile. Will this also hold true if we have a portrait remote media feed on a landscape screen. in that case i can imagine we would like the local tile to be outside the remote tile?
(currently we use the "show grey borders" (fit to frame) approach but in theory it would be nice to have the tile be the correct aspect ratio already)
There was a problem hiding this comment.
Yeah, making it be a child was the easiest way to get the right positioning. As I've commented below I don't know how to account for landscape media, currently (but neither does the old one-on-one layout).
|
Thanks for the suggestions, I'm pretty happy with how the 2:3 aspect ratio looks on mobile now: 
Detecting when the media we're receiving should be landscape is something I don't know how to solve, currently :/ I think that'll have to be outside the scope of this PR. So the best I can do for now is assume that media should be portrait whenever the window is sufficiently narrow, which is the same as how the old one-on-one layout behaves. |
Based on #2416
Closes #1244