-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toggle to always show yourself #2380
Add toggle to always show yourself #2380
Conversation
2a769ce
to
61681dc
Compare
61681dc
to
289c1ef
Compare
289c1ef
to
ab6ba8f
Compare
ab6ba8f
to
f65f072
Compare
f65f072
to
632fe2b
Compare
632fe2b
to
bab4fe1
Compare
bab4fe1
to
632fe2b
Compare
632fe2b
to
0d485ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks.
Can you help me understand the reason local an remote user are different classes instead of a property on the user tile?
src/state/CallViewModel.ts
Outdated
SelfAlwaysShown, | ||
Presenters, | ||
Speakers, | ||
VideoAndAudio, | ||
Video, | ||
Audio, | ||
NoMedia, | ||
SelfEnd, | ||
SelfNotAlwaysShown, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not immediately translate to a bin in my head.
In SelfAlwaysShown
i would expect just myself.
What should i expect in a bin that includes participants that match: SelfNotAlwaysShown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about calling the bin enum sth like BinType since it is not the bin itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say that a SortingBin
is the bin itself, on a conceptual level. In my mind, calling it BinType
would imply that you can instantiate multiple distinct Bin
s for any BinType
, but a Bin
doesn't really need to encode any more information than BinType
does, so… a SortingBin
already seems like a unique reference to the area that we see on screen.
Does that make sense at all? What is a 'bin', to you?
The reason I've split up local and remote user media into different types is that they have distinct sets of properties (local media can be always shown/never shown, remote media has a volume, etc.), and I wanted to enforce that the views that consume them would be fully aware of their differences in functionality. It's the same reason why screen share media has its own type. |
Since you've approved this I'm going to merge it and continue working through the PR stack - I'm happy to iterate later on the |
Based on #2368