Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publisher-s3): ensure published files do not overwrite multiple arches #3108

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

MarshallOfSound
Copy link
Member

I don't think anyone can viably be using this publisher for multiple arches at the moment without using the keyResolver which this change doesn't impact. There's a world where this breaks someone, but I don't think we make any documented guarantees around where the file gets uploaded too exactly in the bucket (maybe we should document that once this lands?)

@erickzhao
Copy link
Member

erickzhao commented Dec 2, 2022

but I don't think we make any documented guarantees around where the file gets uploaded too exactly in the bucket (maybe we should document that once this lands?)

We do document the default key structure at least. It used to only say this:

By default, all files are positioned at the following key:

${config.folder || appVersion}/${artifactName}"

But I added a whole section on using keyResolver as a workaround for the problem this PR is fixing: electron-forge/electron-forge-docs@17e01c5

@mahnunchik
Copy link
Contributor

Let's deal with S3 and GCS publisher together.

Possible improvements for both:

  • common StaticArtifact
  • move s3KeySafe to common utils

@VerteDinde VerteDinde merged commit 6939f09 into main Jun 15, 2023
@VerteDinde VerteDinde deleted the update-compatible-s3 branch June 15, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants