Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: disable CapturableScreen tests on Windows x64 #41544

Merged
merged 2 commits into from Mar 8, 2024
Merged

test: disable CapturableScreen tests on Windows x64 #41544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b944bf
test: disable CapturableScreen tests on Windows x64
jkleinsc Mar 7, 2024
1ca587a
test: disable js-execute-iframe" case should not crash on win 32-bit
jkleinsc Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions spec/crash-spec.ts
View file
Open in desktop
Expand Up @@ -40,9 +40,13 @@ const shouldRunCase = (crashCase: string) => {
case 'quit-on-crashed-event': {
return (process.platform !== 'win32' || process.arch !== 'ia32');
}
// TODO(jkleinsc) fix this test on Linux on arm/arm64
// TODO(jkleinsc) fix this test on Linux on arm/arm64 and 32bit windows
case 'js-execute-iframe': {
return (process.platform !== 'linux' || (process.arch !== 'arm64' && process.arch !== 'arm'));
if (process.platform === 'win32') {
return process.arch !== 'ia32';
} else {
return (process.platform !== 'linux' || (process.arch !== 'arm64' && process.arch !== 'arm'));
}
}
default: {
return true;
Expand Down
4 changes: 2 additions & 2 deletions spec/lib/screen-helpers.ts
View file
Open in desktop
Expand Up @@ -99,8 +99,8 @@ export const areColorsSimilar = (
* - Linux: virtual screen display is 0x0
* - Win32 arm64 (WOA): virtual screen display is 0x0
* - Win32 ia32: skipped
* - Win32 x64: virtual screen display is 0x0
*/
export const hasCapturableScreen = () => {
return process.platform === 'darwin' ||
(process.platform === 'win32' && process.arch === 'x64');
return process.platform === 'darwin';
};