Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update code signing documentation #41535

Merged
merged 1 commit into from Mar 8, 2024

Conversation

felixrieseberg
Copy link
Member

Description of Change

This is the result of the fix Windows codesigning project I signed up for at the last maintainer summit. A quick summary of all the changes:

  • @electron/windows-sign has been created and is now integrated in @electron/packager, electron-winstaller, and electron-wix-msi.
  • All our tooling is now compatible with EV code signing certificate workflows that involve "cloud signing solutions", since you can call a custom binary or JavaScript hook for each file that needs to be signed - even inside Squirrel.Windows, if required.
  • Analogous to @electron/osx-sign, all tools now use the same configuration (windowsSign), so wrapping your head around things is a lot easier.

This PR updates our documentation to document those changes.

Checklist

Release Notes

Notes: no-notes

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours labels Mar 6, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 7, 2024
@VerteDinde VerteDinde added target/29-x-y PR should also be added to the "29-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. labels Mar 8, 2024
@VerteDinde VerteDinde merged commit 4ec4efd into electron:main Mar 8, 2024
24 checks passed
Copy link

release-clerk bot commented Mar 8, 2024

No Release Notes

@trop
Copy link
Contributor

trop bot commented Mar 8, 2024

I have automatically backported this PR to "30-x-y", please check out #41553

@trop trop bot added in-flight/30-x-y and removed target/30-x-y PR should also be added to the "30-x-y" branch. labels Mar 8, 2024
@trop
Copy link
Contributor

trop bot commented Mar 8, 2024

I have automatically backported this PR to "29-x-y", please check out #41554

@trop trop bot added in-flight/29-x-y merged/29-x-y PR was merged to the "29-x-y" branch. merged/30-x-y PR was merged to the "30-x-y" branch. and removed target/29-x-y PR should also be added to the "29-x-y" branch. in-flight/29-x-y in-flight/30-x-y labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 merged/29-x-y PR was merged to the "29-x-y" branch. merged/30-x-y PR was merged to the "30-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants