fix: webContents.print options should be optional #41480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
4 tasks
trop
bot
added
30-x-y
backport
ckerr
approved these changes
Feb 29, 2024
jkleinsc
approved these changes
Mar 2, 2024
jkleinsc
deleted the
trop/30-x-y-bp-fix-webcontents-print-options-should-be-optional-1709220005895
branch
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #41467
See that PR for details.
Notes: Fixes an issue where
webContents.print(options)failed ifoptionswas not passed orundefinedis passed.