Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: chrome://process-internals failing to load #41476

Merged
merged 1 commit into from Mar 7, 2024
Merged

fix: chrome://process-internals failing to load #41476

merged 1 commit into from Mar 7, 2024

Conversation

codebytere
Copy link
Member

Description of Change

Closes #41459.
Refs CL:4472030

Broke in #38033 as a result of the above CL. Updates our pak file to handle changes and allow chrome://process-internals to load again.

Checklist

Release Notes

Notes: Fixed chrome://process-internals failing to load.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/28-x-y PR should also be added to the "28-x-y" branch. target/29-x-y PR should also be added to the "29-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. labels Feb 29, 2024
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 29, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 1, 2024
@codebytere
Copy link
Member Author

Failure:

tag methods .capturePage() returns a Promise with a NativeImage

is known and unrelated.

@codebytere codebytere merged commit f826506 into main Mar 7, 2024
16 of 17 checks passed
@codebytere codebytere deleted the fix-process-internals branch March 7, 2024 14:31
@release-clerk Release Clerk
Copy link

release-clerk bot commented Mar 7, 2024

Release Notes Persisted

Fixed chrome://process-internals failing to load.

This was referenced Mar 7, 2024
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Mar 7, 2024

I have automatically backported this PR to "30-x-y", please check out #41540

@trop trop bot added in-flight/30-x-y and removed target/30-x-y PR should also be added to the "30-x-y" branch. labels Mar 7, 2024
@trop
Copy link
Contributor

trop bot commented Mar 7, 2024

I have automatically backported this PR to "28-x-y", please check out #41541

@trop
Copy link
Contributor

trop bot commented Mar 7, 2024

I have automatically backported this PR to "29-x-y", please check out #41542

@trop trop bot added in-flight/28-x-y in-flight/29-x-y and removed target/28-x-y PR should also be added to the "28-x-y" branch. labels Mar 7, 2024
@trop trop bot added merged/28-x-y PR was merged to the "28-x-y" branch. merged/29-x-y PR was merged to the "29-x-y" branch. merged/30-x-y PR was merged to the "30-x-y" branch. and removed target/29-x-y PR should also be added to the "29-x-y" branch. in-flight/28-x-y in-flight/29-x-y in-flight/30-x-y labels Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@zcbenz zcbenz Awaiting requested review from zcbenz

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees
No one assigned
Labels
merged/28-x-y PR was merged to the "28-x-y" branch. merged/29-x-y PR was merged to the "29-x-y" branch. merged/30-x-y PR was merged to the "30-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot open chrome://process-internals (1.x - 25.x can)
2 participants
@codebytere @deepak1556