Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add logging to uploading to GitHub releases #41453

Merged
merged 1 commit into from Feb 28, 2024

Conversation

jkleinsc
Copy link
Contributor

Description of Change

We continue to see timeout errors when uploading to GitHub for releases, eg https://app.circleci.com/pipelines/github/electron/electron/78872/workflows/7322ac80-17f0-494f-98b4-d4c093653b18/jobs/1679041.

This PR adds additional logging to the script that uploads to GitHub. Additionally the python script that calls that script has been changed to stream the logging instead of waiting until the script is done. Hopefully this will provide enough additional context to diagnose the timeout issue.

Checklist

Release Notes

Notes: none

@jkleinsc jkleinsc added fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. target/29-x-y PR should also be added to the "29-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. labels Feb 27, 2024
@jkleinsc jkleinsc requested a review from a team as a code owner February 27, 2024 22:38
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkleinsc jkleinsc merged commit 267c079 into main Feb 28, 2024
31 checks passed
@jkleinsc jkleinsc deleted the better-logging-release-upload branch February 28, 2024 00:55
Copy link

release-clerk bot commented Feb 28, 2024

No Release Notes

@trop
Copy link
Contributor

trop bot commented Feb 28, 2024

I have automatically backported this PR to "30-x-y", please check out #41455

@trop trop bot added in-flight/30-x-y and removed target/30-x-y PR should also be added to the "30-x-y" branch. labels Feb 28, 2024
@trop
Copy link
Contributor

trop bot commented Feb 28, 2024

I have automatically backported this PR to "28-x-y", please check out #41456

@trop
Copy link
Contributor

trop bot commented Feb 28, 2024

I have automatically backported this PR to "27-x-y", please check out #41457

@trop
Copy link
Contributor

trop bot commented Feb 28, 2024

I have automatically backported this PR to "29-x-y", please check out #41458

@trop trop bot added in-flight/27-x-y in-flight/29-x-y merged/30-x-y PR was merged to the "30-x-y" branch. and removed target/28-x-y PR should also be added to the "28-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. target/29-x-y PR should also be added to the "29-x-y" branch. in-flight/30-x-y labels Feb 28, 2024
@trop trop bot added merged/29-x-y PR was merged to the "29-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. and removed in-flight/29-x-y in-flight/27-x-y in-flight/28-x-y labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. merged/29-x-y PR was merged to the "29-x-y" branch. merged/30-x-y PR was merged to the "30-x-y" branch. semver/none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants