fix: don't check for Desktop Environment in unity_service.cc

[JakobDev]

Description of Change

Electron uses libunity to implement setProgressBar and setBadgeCount. The Unity Launcher API is currently supported by multiple Programs and Desktop. Electron cheeks for some reason which desktop environment the User is using.

This is completely pointless. libunity just emits a DBus signal. If a Desktop Environment don't support the API, it just don't listen to the signal, so there is no harm when emitting this signal.

On the other hand, this Signal is supported by various Software such as the Dash to Dock or Plank. If Electron checks the Desktop Environment, it will not work, unset you set XDG_CURRENT_DESKTOP=KDE.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant documentation, tutorials, templates and examples are changed or added
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Don't check for Desktop Environment in setProgressBar and setBadgeCount.

[welcome]

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

• fix: don't overwrite prevent_default if default wasn't prevented
• feat: add app.isPackaged() method
• docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

• Follow the JavaScript, C++, and Python coding style.
• Run npm run lint locally to catch formatting errors earlier.
• Document any user-facing changes you've made following the documentation styleguide.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[codebytere]

@JakobDev can you please explain what is meant by:

On the other hand, this Signal is supported by various Software such as the Dash to Dock or Plank. If Electron checks the Desktop Environment, it will not work, unset you set XDG_CURRENT_DESKTOP=KDE.

Supported to what extent? What functionality is lost with our logic? This logic is also borrowed directly from Chromium - this was originally added for https://bugs.chromium.org/p/chromium/issues/detail?id=338204. Is that outdated there as well?

Finally - it would help if you could open a bug report and link to this PR to shed more light on the issue it's addressing.

[JakobDev]

Finally - it would help if you could open a bug report and link to this PR to shed more light on the issue it's addressing.

Here you go

Is that outdated there as well?

Yes. In fact you should not even use libunity any more, as it's outdated. You should rather emit the DBus signal directly, but that's another Issue.

[JakobDev]

Any news on this?

[release-clerk]

Release Notes Persisted

Don't check for Desktop Environment in setProgressBar and setBadgeCount.