Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failure on immutable webContents.print(options) #39985

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix: failure on immutable webContents.print(options) #39985

merged 1 commit into from
Sep 28, 2023

Conversation

codebytere
Copy link
Member

Description of Change

Closes #38837.

Fixes an issue where webContents.print could fail when options is a frozen object.

Checklist

Release Notes

Notes: Fixed an issue where webContents.print could fail when options is a frozen object.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. labels Sep 26, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 26, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 27, 2023
@codebytere codebytere merged commit c8156c3 into main Sep 28, 2023
17 checks passed
@codebytere codebytere deleted the fix-printing-immutable branch September 28, 2023 08:41
@release-clerk
Copy link

release-clerk bot commented Sep 28, 2023

Release Notes Persisted

Fixed an issue where webContents.print could fail when options is a frozen object.

This was referenced Sep 28, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Sep 28, 2023

I have automatically backported this PR to "25-x-y", please check out #40028

@trop trop bot mentioned this pull request Sep 28, 2023
Merged
@trop trop bot removed the target/25-x-y PR should also be added to the "25-x-y" branch. label Sep 28, 2023
@trop
Copy link
Contributor

trop bot commented Sep 28, 2023

I have automatically backported this PR to "26-x-y", please check out #40029

@trop
Copy link
Contributor

trop bot commented Sep 28, 2023

I have automatically backported this PR to "27-x-y", please check out #40030

@trop trop bot added in-flight/26-x-y in-flight/27-x-y merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. and removed target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. in-flight/25-x-y labels Sep 28, 2023
@trop trop bot added merged/27-x-y PR was merged to the "27-x-y" branch. and removed in-flight/26-x-y in-flight/27-x-y labels Sep 28, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere
fix: failure on immutable webContents.print(options) (electron#39985)
4d6db96 
fix: failure on immutable webContents.print(options)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: webContents.print() fails for immutable object parameter
2 participants
@codebytere @jkleinsc