Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure app load is limited to real asar files when appropriate #39788

Merged
merged 1 commit into from Sep 11, 2023
Merged

fix: ensure app load is limited to real asar files when appropriate #39788

merged 1 commit into from Sep 11, 2023

Conversation

MarshallOfSound
Copy link
Member

Just because something exists in a *.asar path doesn't mean it's actually an asar file.

Notes: no-notes

@MarshallOfSound MarshallOfSound added target/22-x-y PR should also be added to the "22-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. labels Sep 9, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 9, 2023
@MarshallOfSound MarshallOfSound added the semver/patch backwards-compatible bug fixes label Sep 9, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 10, 2023
@MarshallOfSound MarshallOfSound merged commit 16aec70 into main Sep 11, 2023
26 of 27 checks passed
@MarshallOfSound MarshallOfSound deleted the ensure-asar-is-asar branch September 11, 2023 18:51
@release-clerk
Copy link

release-clerk bot commented Sep 11, 2023

No Release Notes

This was referenced Sep 11, 2023
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Sep 11, 2023

I have automatically backported this PR to "27-x-y", please check out #39807

@trop
Copy link
Contributor

trop bot commented Sep 11, 2023

I have automatically backported this PR to "26-x-y", please check out #39808

@trop trop bot mentioned this pull request Sep 11, 2023
Merged
@trop trop bot added in-flight/26-x-y and removed target/27-x-y PR should also be added to the "27-x-y" branch. labels Sep 11, 2023
@trop trop bot mentioned this pull request Sep 11, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Sep 11, 2023

I have automatically backported this PR to "25-x-y", please check out #39809

@trop trop bot added in-flight/25-x-y and removed target/26-x-y PR should also be added to the "26-x-y" branch. labels Sep 11, 2023
@trop
Copy link
Contributor

trop bot commented Sep 11, 2023

I have automatically backported this PR to "24-x-y", please check out #39810

@trop
Copy link
Contributor

trop bot commented Sep 11, 2023

I have automatically backported this PR to "22-x-y", please check out #39811

@trop trop bot removed the target/25-x-y PR should also be added to the "25-x-y" branch. label Sep 11, 2023
@trop trop bot added in-flight/24-x-y merged/25-x-y PR was merged to the "25-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch merged/22-x-y PR was merged to the "22-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. and removed target/24-x-y PR should also be added to the "24-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. in-flight/25-x-y in-flight/24-x-y in-flight/27-x-y in-flight/26-x-y labels Sep 11, 2023
@Drarig29
Copy link

Drarig29 commented Dec 7, 2023

Hi @MarshallOfSound! It seems like this PR wasn't backported to 23.x.y.

In GHSA-7m48-wc93-9g85, we can see that it should have been published as 23.3.14, but that version doesn't exist 🤔

MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@MarshallOfSound
fix: ensure app load is limited to real asar files when appropriate (e…
7d8a959 
…lectron#39788)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

Assignees
No one assigned
Labels
merged/22-x-y PR was merged to the "22-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarshallOfSound @Drarig29 @codebytere