Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent errors when extensions listen for chrome.tabs events #39770

Merged
merged 2 commits into from Sep 7, 2023
Merged

fix: prevent errors when extensions listen for chrome.tabs events #39770

merged 2 commits into from Sep 7, 2023

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 7, 2023

Backport of #39729

See that PR for details.

Notes: Fixed an error where listening to certain chrome.tabs events would throw incorrectly.

trop bot and others added 2 commits September 7, 2023 10:41
@trop @codebytere
fix: prevent errors when extensions listen for chrome.tabs events
d6af8dd 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop @codebytere
chore: mark events unsupported in Electron
10eb490 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop bot requested a review from codebytere September 7, 2023 10:42
@trop trop bot mentioned this pull request Sep 7, 2023
Merged
4 tasks
@trop trop bot added 25-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Sep 7, 2023
@jkleinsc jkleinsc merged commit 149f314 into 25-x-y Sep 7, 2023
13 checks passed
@jkleinsc jkleinsc deleted the trop/25-x-y-bp-fix-prevent-errors-when-extensions-listen-for-chrome-tabs-events-1694083311136 branch September 7, 2023 13:20
@release-clerk
Copy link

release-clerk bot commented Sep 7, 2023

Release Notes Persisted

Fixed an error where listening to certain chrome.tabs events would throw incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
25-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkleinsc @codebytere