Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore flag that allowed websockets to not be backgrounded #39738

Merged
merged 1 commit into from Sep 6, 2023
Merged

fix: restore flag that allowed websockets to not be backgrounded #39738

merged 1 commit into from Sep 6, 2023

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Sep 5, 2023 •
edited

Temporary measure while we figure out a better API-driven approach to allowing Electron apps to opt renderers out of being aggressively throttled

Notes: no-notes

@MarshallOfSound MarshallOfSound requested a review from a team as a code owner September 5, 2023 20:23
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 5, 2023
@MarshallOfSound MarshallOfSound added semver/patch backwards-compatible bug fixes target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. and removed new-pr 🌱 PR opened in the last 24 hours labels Sep 5, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 5, 2023
@MarshallOfSound MarshallOfSound added target/25-x-y PR should also be added to the "25-x-y" branch. and removed target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. labels Sep 5, 2023
@deepak1556
Copy link
Member

Temporary measure while we figure out a better API-driven approach to allowing Electron apps to opt renderers out of being aggressively throttled

Are you considering a new API over the current backgroundThrottling webPreference we provide today for renderer ?

@MarshallOfSound
Copy link
Member Author

Are you considering a new API over the current backgroundThrottling webPreference we provide today for renderer ?

Potentially something more fine grained yeah, or at a minimum just fixing that option because it really doesn't work rn 😂

@MarshallOfSound MarshallOfSound merged commit 65901f4 into main Sep 6, 2023
16 of 17 checks passed
@MarshallOfSound MarshallOfSound deleted the allow-websocket-opt-out branch September 6, 2023 18:23
@release-clerk
Copy link

release-clerk bot commented Sep 6, 2023

No Release Notes

@trop trop bot mentioned this pull request Sep 6, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Sep 6, 2023

I have automatically backported this PR to "25-x-y", please check out #39753

@trop trop bot added the in-flight/25-x-y label Sep 6, 2023
@trop trop bot mentioned this pull request Sep 6, 2023
Merged
@trop trop bot removed the target/25-x-y PR should also be added to the "25-x-y" branch. label Sep 6, 2023
@trop trop bot mentioned this pull request Sep 6, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Sep 6, 2023

I have automatically backported this PR to "26-x-y", please check out #39754

@trop
Copy link
Contributor

trop bot commented Sep 6, 2023

I have automatically backported this PR to "27-x-y", please check out #39755

@trop trop bot added the in-flight/26-x-y label Sep 6, 2023
@trop trop bot added in-flight/27-x-y merged/27-x-y PR was merged to the "27-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. and removed target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. in-flight/27-x-y in-flight/26-x-y labels Sep 6, 2023
@trop trop bot added merged/25-x-y PR was merged to the "25-x-y" branch. and removed in-flight/25-x-y labels Sep 19, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@MarshallOfSound
fix: restore flag that allowed websockets to not be backgrounded (ele…
fb0ab06 
…ctron#39738)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MarshallOfSound @deepak1556 @codebytere @VerteDinde