fix: devtools allow restoring saved dock state on Windows #39734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
added
semver/patch
codebytere
reviewed
Sep 5, 2023
deepak1556
force-pushed
the
robo/fix_default_dock_pos_win
branch
from
50a7680
to
c152b61
Compare
codebytere
force-pushed
the
robo/fix_default_dock_pos_win
branch
from
c152b61
to
e017d68
Compare
codebytere
approved these changes
Sep 6, 2023
zcbenz
approved these changes
Sep 7, 2023
|
Failing tests are unrelated, merging. |
|
Release Notes Persisted
|
|
I have automatically backported this PR to "25-x-y", please check out #39766 |
trop
bot
removed
the
target/25-x-y
|
I have automatically backported this PR to "27-x-y", please check out #39767 |
|
I have automatically backported this PR to "26-x-y", please check out #39768 |
trop
bot
added
in-flight/27-x-y
in-flight/26-x-y
and removed
target/27-x-y
trop
bot
added
merged/27-x-y
3 tasks
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
…9734) * fix: devtools allow restoring saved dock state on Windows * chore: address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
#35209 defaulted to
detachposition when opening devtools without any predefined state to workaround a bug in chromium, this took away the docking feature of devtools on Windows. #35754 was later added to respect thestateoption when opening devtools, although it is a good enough solution it takes away the option to rely on preferred dock state persisted to user data dir when opening devtools without any arguments.This PR attempts to respect the persisted preferred dock state when WCO is enabled on Windows and instead of detaching the devtools it will now
undockdepending the dock state corresponding to the position of window controls. This allows users to still have control over the dock position without the application enforcing it.Needed for microsoft/vscode#168454
Release Notes
Notes: fix devtools to allow restoring saved dock state on Windows