fix: ensure windows respect fullscreenability with different resizability values #39620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parent is fullscreen
codebytere
added
semver/patch
codebytere
changed the title
jkleinsc
approved these changes
Aug 24, 2023
|
Release Notes Persisted
|
|
I have automatically backported this PR to "27-x-y", please check out #39640 |
trop
bot
removed
the
target/27-x-y
This was referenced Aug 24, 2023
|
I have automatically backported this PR to "26-x-y", please check out #39641 |
|
I have automatically backported this PR to "25-x-y", please check out #39642 |
|
I have automatically backported this PR to "24-x-y", please check out #39643 |
trop
bot
added
merged/27-x-y
3 tasks
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
…lity values (electron#39620) * fix: ensure child windows respect fullscreenability/resizability when parent is fullscreen * test: add an extra resize test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #39614
Closes #39630.
Fixes an issue where child windows opened when the parent window is already fullscreen did not respect the child windows' fullscreenability and resizability settings.
Confirmed not to regress #39077.
Tested with https://gist.github.com/pushkin-/3b4bcdb219eee85789e95f6d94ec8a92
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where child windows opened when the parent window is already fullscreen did not respect the child windows' fullscreenability and resizability settings.