Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: chrome.tabs 'url' and 'title' are privileged information #39595

Merged
merged 1 commit into from Aug 22, 2023
Merged

fix: chrome.tabs 'url' and 'title' are privileged information #39595

merged 1 commit into from Aug 22, 2023

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Aug 21, 2023 •
edited

Description of Change

This PR does two things:

  • Addresses a longstanding TODO to protect privileged tabs.Tab data when invoking chrome.tabs.get, chrome.tabs.query, and chrome.tabs.update.
  • Fix support for the tabs permission

This matches upstream behavior per documentation and fixes the following issue:

Tabs Permission Error 

(node:84039) ExtensionLoadWarning: Warnings loading extension at /Users/codebytere/Developer/electron-gn/src/electron/spec/fixtures/extensions/chrome-tabs/api-async:
  Permission 'tabs' is unknown or URL pattern is malformed.

Checklist

Release Notes

Notes: Fixed an issue where certain properties of chrome.tabs Tab objects were not properly considered privileged.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. labels Aug 21, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 21, 2023
@codebytere codebytere mentioned this pull request Aug 21, 2023
Merged
5 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 22, 2023
@codebytere codebytere merged commit e1d6379 into main Aug 22, 2023
17 checks passed
@codebytere codebytere deleted the fix-privileged-access-tabs branch August 22, 2023 12:57
@release-clerk
Copy link

release-clerk bot commented Aug 22, 2023

Release Notes Persisted

Fixed an issue where certain properties of chrome.tabs Tab objects were not properly considered privileged.

This was referenced Aug 22, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Aug 22, 2023

I have automatically backported this PR to "26-x-y", please check out #39607

@trop trop bot mentioned this pull request Aug 22, 2023
Merged
@trop trop bot removed the target/26-x-y PR should also be added to the "26-x-y" branch. label Aug 22, 2023
@trop
Copy link
Contributor

trop bot commented Aug 22, 2023

I have automatically backported this PR to "27-x-y", please check out #39608

@trop
Copy link
Contributor

trop bot commented Aug 22, 2023

I have automatically backported this PR to "25-x-y", please check out #39609

@trop trop bot added in-flight/27-x-y in-flight/25-x-y merged/25-x-y PR was merged to the "25-x-y" branch. and removed target/27-x-y PR should also be added to the "27-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. in-flight/25-x-y labels Aug 22, 2023
@trop trop bot added merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. and removed in-flight/26-x-y in-flight/27-x-y labels Aug 22, 2023
win32ss pushed a commit to win32ss/supermium-electron that referenced this pull request Sep 24, 2023
@codebytere
fix: chrome.tabs 'url' and 'title' are privileged information (elec…
743b520 
…tron#39595)

fix: tabs url and title are privileged information
@commit-lint commit-lint bot mentioned this pull request Nov 15, 2023
Open
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere
fix: chrome.tabs 'url' and 'title' are privileged information (elec…
b40cc85 
…tron#39595)

fix: tabs url and title are privileged information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@samuelmaddock samuelmaddock Awaiting requested review from samuelmaddock

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @zcbenz