Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dangling raw_ptr in ElectronBrowserMainParts dtor #39594

Merged
merged 2 commits into from
Aug 21, 2023
Merged

fix: dangling raw_ptr in ElectronBrowserMainParts dtor #39594

merged 2 commits into from
Aug 21, 2023

Commits on Aug 21, 2023

  1. fix: dangling raw_ptr in ElectronBrowserMainParts dtor 

    Co-authored-by: Charles Kerr <charles@charleskerr.com>
    @trop @ckerr
    trop[bot] and ckerr committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    1b3d812 View commit details
    Browse the repository at this point in the history

  2. fixup! fix: dangling raw_ptr in ElectronBrowserMainParts dtor 

    Browser::WhenReady() holds a reference to JsEnv isolate so must come after

Co-authored-by: Charles Kerr <charles@charleskerr.com>
    @trop @ckerr
    trop[bot] and ckerr committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    8c51f5e View commit details
    Browse the repository at this point in the history